GH-3618: Ban JUnit4 imports#3681
Merged
Merged
Conversation
Contributor
Author
nastra
force-pushed
the
enforce-junit5-imports
branch
from
July 22, 2026 05:57
5b96df2 to
b37ed2f
Compare
wgtmac
approved these changes
Jul 22, 2026
Member
|
Do we need to rebase current open PRs if this gets merged? |
Contributor
Author
yes, but those PRs will have to be rebased most likely anyway due to the other AssertJ + JUnit5 changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This bans JUnit4 imports and forces people to use JUnit5 + AssertJ
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
no